Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug related to blight and add a feature for brightness #67

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

Albert24GG
Copy link
Contributor

@Albert24GG Albert24GG commented Dec 15, 2023

When using this program I noticed that when changing brightness quickly(ex: raise it two times and then lower it), the indicator(osd bar) would not reflect these changes(in case of the previous example it would raise when I lower the brightness). So I found out that the current brightness of the blight device does not update properly. Reloading the device current value solved this issue.
Another problem I found is that there was no way to change the brightness by a custom delta anymore(this was possible before), so I added some code that checks if the argument is signed or not and applies the changes(if there's no sign, then that means the user wants to set the brightness to that value).
LE: This PR fixes #68.

@Albert24GG
Copy link
Contributor Author

@ErikReider Hey, did you have time to look over this PR? Is there any changes I have to make? Thanks!

Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM :)

src/global_utils.rs Outdated Show resolved Hide resolved
Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@ErikReider ErikReider merged commit ac6c376 into ErikReider:main Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise/lower brightness by specific amount
2 participants