Fix bug related to blight and add a feature for brightness #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ErikReider Hey, did you have time to look over this PR? Is there any changes I have to make? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this program I noticed that when changing brightness quickly(ex: raise it two times and then lower it), the indicator(osd bar) would not reflect these changes(in case of the previous example it would raise when I lower the brightness). So I found out that the current brightness of the blight device does not update properly. Reloading the device current value solved this issue.
Another problem I found is that there was no way to change the brightness by a custom delta anymore(this was possible before), so I added some code that checks if the argument is signed or not and applies the changes(if there's no sign, then that means the user wants to set the brightness to that value).
LE: This PR fixes #68.