-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add percentage labels to volume and brightness indicators #69
Add percentage labels to volume and brightness indicators #69
Conversation
b172bef
to
25e69ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also prefer if the user could disable this. Might wait with this until config support has been added to undo some of the cmdline arg clutter
25e69ae
to
9e12cd5
Compare
Yes, that is my thought as well. I'm completely fine with leaving this PR hanging until config support is added, I might even help with implementing config support if I find time. |
c6f84c5
to
c9b6d0d
Compare
Rebased on top of #79 and added a configuration option to enable percentage display. |
c9b6d0d
to
04a6652
Compare
I'll wait until #79 is merged :) |
04a6652
to
2463549
Compare
07f7107
to
c6c9604
Compare
c6c9604
to
0a0cb61
Compare
rebased onto the merged config branch and updated the PR description. |
@ErikReider I think this can be merged |
@ErikReider if you'd like to reduce the number of things in the CLI options I can also remove the CLI option added in this PR (I already have a fixup commit for that locally, I'd just need to push it) |
That would be appreciated! :D |
0a0cb61
to
2e2c1bb
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience! :)
This PR adds a textual percentage next to the progress bar in the volume and brightness indicators. This is useful for users who still want to know the exact volume percentage set in practice.
This is off by default and can be enabled with the
show_percentage
boolean setting in the[server]
block inCONFIG_HOME/swayosd/config.toml
.Example config: