Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

More scores #203

Merged
merged 10 commits into from
May 24, 2016
Merged

More scores #203

merged 10 commits into from
May 24, 2016

Conversation

tjorim
Copy link
Collaborator

@tjorim tjorim commented May 21, 2016

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

tjorim added 3 commits May 17, 2016 20:21
This is the first step towards a personal top10/logbook.
The array is not saved in storage yet.
This stores scores in an array and shows an additional overlay;
some functions were cleaned up as well.
BTW: I changed the 'colour' to 'color', sorry Britain.
var original_redraw = window.redraw.toString();
var new_redraw = original_redraw.replace(
'gsc!=f&&(gsc<f?(gsc+=2E-4,gsc>=f&&(gsc=f)):(gsc-=2E-4,gsc<=f&&(gsc=f)))', '');
window.redraw = new Function(new_redraw.substring(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Function constructor is eval.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not this again -_- (ignore)

Giving a treat to the Hound.
}
behaviorData: {
foodTarget: 0,
followTime :0,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space after key "followTime".
Missing space before value for key "followTime".

//Canvas Coordinates
// X = 0 -> CanvasWidth
// Y = 0 -> CanvasHeight

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces not allowed.

Adding newline at the end.

canvas.drawLine2(canvasPosA.x, canvasPosA.y, canvasPosB.x, canvasPosB.y, 2, 'yellow');
canvas.drawLine(canvasPosA, canvasPosB, 'yellow', 2);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"canvas" is not defined.

Copy link
Collaborator Author

@tjorim tjorim May 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore, canvas is a module in bot.user.js. Hound does not know this.

More trailing spaces, damnit np++.
bot.isBotRunning = false;
// Update the HUD
userInterface.onPrefChange();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"userInterface" was used before it was defined

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore, just the arrangement of modules.

@ermiyaeskandary
Copy link
Owner

ermiyaeskandary commented May 22, 2016

I think I can fix this module issue...

@tyschnoor
Copy link

This is amazing!

@ermiyaeskandary
Copy link
Owner

ermiyaeskandary commented May 24, 2016

Approved

Approved with PullApprove

@ermiyaeskandary ermiyaeskandary merged commit 8c223ce into master May 24, 2016
@ermiyaeskandary ermiyaeskandary deleted the more-scores branch May 24, 2016 05:59
@Drflash55
Copy link
Collaborator

Lol, I love it how hound keeps finding errors that are blatantly not errors at all...

@tjorim tjorim mentioned this pull request Jun 4, 2016
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants