Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages/2 #3

Merged
merged 4 commits into from
May 14, 2021
Merged

Pages/2 #3

merged 4 commits into from
May 14, 2021

Conversation

shdpl
Copy link
Contributor

@shdpl shdpl commented May 13, 2021

No description provided.

shdpl added 3 commits May 12, 2021 19:24
…odel and seeder [service provider] init [controllers] empty method stubs [requests] empty request stubs [services] empty service stub [routes] empty route file [tests] initial test-case and trivial model test
@shdpl shdpl linked an issue May 13, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@45a2fdd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   42.85%           
  Complexity      ?        8           
=======================================
  Files           ?        4           
  Lines           ?       21           
  Branches        ?        0           
=======================================
  Hits            ?        9           
  Misses          ?       12           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a2fdd...4d16fa5. Read the comment docs.

database/factories/PageFactory.php Outdated Show resolved Hide resolved
src/Http/Controllers/Contracts/PagesApiContract.php Outdated Show resolved Hide resolved
src/routes.php Outdated Show resolved Hide resolved
Copy link
Contributor

@HerbertIV HerbertIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok

[seeders] remove page table seeder
[swagger] remove passport annotation from read-page request
[routes]  use short-form for the route group
@qunabu qunabu self-requested a review May 14, 2021 12:38
@qunabu qunabu merged commit c80c94c into main May 14, 2021
@qunabu qunabu deleted the pages/2 branch May 14, 2021 12:41
@shdpl shdpl linked an issue May 17, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin should be able to create pages Create a model for pages
3 participants