Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

references are enabled by default? #617

Closed
tianshouzhi opened this issue Aug 26, 2018 · 3 comments
Closed

references are enabled by default? #617

tianshouzhi opened this issue Aug 26, 2018 · 3 comments

Comments

@tianshouzhi
Copy link

the document mentioned "By default references are not enabled",but when I test with 5.0.0-RC1,I found Kryo.getReferences() return true.

@NathanSweet
Copy link
Member

You're right. This happens because a ReferenceResolver is provided by default, which then enables references. The docs say it is disabled by default, setReferences javadoc says "Default is true.". Who to believe?! We can decide either way. I think it makes sense for the defaults to have most features disabled, especially those which add overhead, as references do. Any naysayers should speak now! In the meantime, I'll wait for Eclipse to be able to run unit tests again.

@isaki
Copy link
Contributor

isaki commented Sep 3, 2018

I vote that references be disabled by default; I agree that the defaults should be as barebones as possible and developers/users should opt into features (and thus be aware of what overhead they are incurring).

@magro
Copy link
Collaborator

magro commented Dec 27, 2018

@NathanSweet should this be resolved before the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants