Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flutter] Use FilterQuality.medium instead of FilterQuality.high #2362

Closed
spydon opened this issue Sep 12, 2023 · 3 comments
Closed

[Flutter] Use FilterQuality.medium instead of FilterQuality.high #2362

spydon opened this issue Sep 12, 2023 · 3 comments

Comments

@spydon
Copy link

spydon commented Sep 12, 2023

Regardless of the names, FilterQuality.medium actually almost always gives a better rendering output than FilterQuality.high, except when you need to scale up a lot, which I don't think is the case here.

I think this is the only place that needs to be changed:
https://github.com/EsotericSoftware/spine-runtimes/blob/4.2-beta/spine-flutter/lib/spine_flutter.dart#L140

I could provide a PR, but seems like more effort to sign the CLA etc than someone internally just doing that one-liner.

@badlogic
Copy link
Collaborator

I'll happily add this manually. I wonder if we should make it configurable though. What do you think @spydon ?

@spydon
Copy link
Author

spydon commented Sep 12, 2023

Sounds like a good idea, that's what we did in Flame, but defaulting to medium. :)

@badlogic
Copy link
Collaborator

Fixed in the latest releases. You can configure it via Atlas.filterQuality. Default is now medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants