Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scripts fail out on error #114

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Make scripts fail out on error #114

merged 2 commits into from
Jan 12, 2023

Conversation

Ancient123
Copy link
Member

@Ancient123 Ancient123 commented Jan 11, 2023 •
edited by alxiong
Loading

Major changes include:

  • make scripts fail on error
  • fix run_tests.sh script

alxiong
alxiong approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @chancharles92 to double approve

@chancharles92
Copy link
Collaborator

I'll let @chancharles92 to double approve

Thanks, approved.

@Ancient123 Ancient123 merged commit 38a0d3c into main Jan 12, 2023
@Ancient123 Ancient123 deleted the scripts branch January 12, 2023 17:00
@chancharles92 chancharles92 mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxiong alxiong alxiong approved these changes

@chancharles92 chancharles92 chancharles92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ancient123 @chancharles92 @alxiong