Added support for default values, including in hiearchies #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmfenton
reviewed
Feb 13, 2018
lib/adlib.js
Outdated
| @@ -12,6 +12,7 @@ function isString(v) { | |||
|
|
|||
| function _swap(parameter, settings, transforms) { | |||
| let value; | |||
| console.info(`_swap: param: ${parameter}`); | |||
There was a problem hiding this comment.
left this little guy behind
akharris
reviewed
Feb 13, 2018
lib/adlib.js
Outdated
| let hbsEntries = templateValue.match(handlebars); | ||
|
|
||
| if (hbsEntries && hbsEntries.length) { | ||
| console.log(`Got a ${hbsEntries.length} handlebar entries...`); |
There was a problem hiding this comment.
we can probably remove this console.log
akharris
reviewed
Feb 13, 2018
lib/adlib.js
Outdated
| let numberOfPaths = paths.length; | ||
| // here we check each option, in order, and return the first with a value in the hash, OR the last | ||
| path = paths.find((pathOption, idx) => { | ||
| console.info(`Checking to see if ${pathOption} is in settings hash...`); |
akharris
reviewed
Feb 13, 2018
lib/adlib.js
Outdated
| values.forEach((v) => { | ||
| // console.log(`Comparing ${templateValue} with ${v.key}`) | ||
| if (templateValue == v.key) { |
There was a problem hiding this comment.
I think this was my mistake from earlier but this should probably be a ===
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports strings, urls, int and float
Closes #21