Saniziting HTML attributes #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Data can now be sanitized before being put into HTML attribute values. Front-end frameworks like React have decent XSS protection for things injected as children elements, but not much protection for untrusted values being put into HTML attributes (like
alttag on image,hrefon anchor,styleon div,backgroundon body, etc).Details
js-xss'ssafeAttrValue()with a new instance method --sanitizeHTMLAttribute(), which takes in the same parameters.sanitizeHTMLAttribute()uses the customsafeAttrValue()if one is provided to theSanitizerconstructorChanges
this._xssFilter's type