Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

df/FloatingPanelEnhancements #108

Merged
merged 40 commits into from
Aug 23, 2022
Merged

Conversation

dfeinzimer
Copy link
Collaborator

See #14

  • Switches floating panel to be exposed as a view modifier
  • Adds sheet behavior/appearance for compact environments
  • Adds additional customization like background color, width, horizontal alignment
  • Adds the ability to programmatically control height
  • Snaps to preset heights when user drags the handle

To see these changes in action, try the Utility Network Sample in the FloatingPanelDemo branch.

@dfeinzimer dfeinzimer self-assigned this Jul 29, 2022
@dfeinzimer dfeinzimer linked an issue Jul 29, 2022 that may be closed by this pull request
6 tasks
@dfeinzimer dfeinzimer marked this pull request as ready for review July 30, 2022 00:35
@rolson
Copy link
Contributor

rolson commented Aug 3, 2022

I'm seeing the trace button probably too close to the bottom safe area in the demo:

image

@rolson
Copy link
Contributor

rolson commented Aug 3, 2022

Question: do we need the shadow? I'm not seeing a shadow on this one from the color picker, but maybe the color picker is a bit more modal like a sheet so it grays out the BG a bit?

image

@dfeinzimer dfeinzimer mentioned this pull request Aug 9, 2022
@mhdostal
Copy link
Member

The "Trace" button is still butting up against the handle view; I think it could use a little padding.

image

@mhdostal
Copy link
Member

When dragging the handle up or down in Apple Maps, the speed at which you drag helps dictate whether the floating panel moves to the next detent. Move a little bit slowly does not; moving a little bit quickly, does. You could base the decision to go to the next detent on the position AND velocity of the drag. I'm OK with creating another issue for this and tackling it separately.

@mhdostal
Copy link
Member

It would be nice if we had a custom "summary" detent height (or a "minimumHeight), to allow at least a minimum height needed to display a view's "summary" information. Again, this can be a future issue.

Copy link
Member

@mhdostal mhdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! I like the new additions.

@dfeinzimer
Copy link
Collaborator Author

The "Trace" button is still butting up against the handle view; I think it could use a little padding.

I've increased the height of the handle area.

...You could base the decision to go to the next detent on the position AND velocity of the drag...

Opened #132

It would be nice if we had a custom "summary" detent height (or a "minimumHeight), to allow at least a minimum height needed to display a view's "summary" information. Again, this can be a future issue.

Opened #133

@dfeinzimer dfeinzimer merged commit 7ace937 into v.next Aug 23, 2022
@dfeinzimer dfeinzimer deleted the df/FloatingPanelEnhancements branch August 23, 2022 19:35
@dfeinzimer dfeinzimer mentioned this pull request Nov 4, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating Panel Enhancements
3 participants