Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: new addItemResource method #285

Merged
merged 3 commits into from
Aug 17, 2018
Merged

Feature: new addItemResource method #285

merged 3 commits into from
Aug 17, 2018

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Aug 16, 2018 •
edited
Loading

ref: https://developers.arcgis.com/rest/users-groups-and-items/add-resources.htm

i couldn't take it anymore so i rearranged our menagerie of item methods into unique files.

the new stuff is in ebbdc7e

@coveralls
Copy link

coveralls commented Aug 16, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a26b935 on feat/add-item-resource into 89edac5 on master.

tomwayson
tomwayson approved these changes Aug 17, 2018
View reviewed changes
Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we should cut a patch release w/ #286 before releasing this?

@jgravois
Copy link
Contributor Author

why not just release both at the same time?

@jgravois
chore(items): break out item methods into individual files
be17cab 
for legibility

AFFECTS PACKAGES:
@esri/arcgis-rest-items
@jgravois
feat(resources): new method to add a new resource to an item
9c63075 
AFFECTS PACKAGES:
@esri/arcgis-rest-items

ISSUES CLOSED: #281
@jgravois
fix(search): ensure searchItems can mixin arbitrary parameters with a…
a26b935 
… searchform

AFFECTS PACKAGES:
@esri/arcgis-rest-items
@jgravois
Copy link
Contributor Author

ghetto npm linked in EAPS to do a real world test and addItemResource method was 👍

@jgravois jgravois merged commit 5e8e519 into master Aug 17, 2018
@jgravois jgravois deleted the feat/add-item-resource branch August 17, 2018 16:21
@jgravois jgravois mentioned this pull request Sep 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwayson tomwayson tomwayson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgravois @coveralls @tomwayson