Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: calcite-pick-list: two issues with RTL #959

Closed
AdelheidF opened this issue May 6, 2020 · 6 comments
Closed

Bug: calcite-pick-list: two issues with RTL #959

AdelheidF opened this issue May 6, 2020 · 6 comments
Assignees
Labels
4 - verified bug Something isn't working

Comments

@AdelheidF
Copy link

Summary

2 issues
1.) open menu not fully visible in RTL
2.) search magnifying icon on wrong side in RTL

LTR:

RTL:

<calcite-dropdown slot="menu-actions" alignment="end">
        <calcite-action
          key="attribute-selector-sort"
          slot="dropdown-trigger"
          label={i18n.ui.sortFields}
          aria-label={i18n.ui.sortFields}
        >
          <calcite-icon scale="s" icon="sortDescending"></calcite-icon>
        </calcite-action>
        <calcite-dropdown-group grouptitle={i18n.ui.sortBy}>
          <calcite-dropdown-item ... >
            {i18n.ui.sortByDisplayName}
          </calcite-dropdown-item>
          ...
        </calcite-dropdown-group>
      </calcite-dropdown>

Actual Behavior

Expected Behavior

Reproduction Steps

Relevant Info

@asangma
Copy link
Contributor

asangma commented May 6, 2020

@AdelheidF Looks like it's a calcite-components issue. I posted an issue there.

@asangma
Copy link
Contributor

asangma commented May 6, 2020

Correction, the DropDown issue appears to be calcite-components. I'll look at the search icon.

@asangma asangma self-assigned this May 6, 2020
@asangma asangma assigned jcfranco and unassigned asangma May 6, 2020
@asangma
Copy link
Contributor

asangma commented May 6, 2020

@jcfranco It looks for the search icon in calcite-filter, the styles are there to place it correctly in RTL but calcite-filter isn't checking for RTL. ¯_(ツ)_/¯

@asangma
Copy link
Contributor

asangma commented May 7, 2020

Assigning back to me.

@asangma asangma assigned asangma and unassigned jcfranco May 7, 2020
@asangma asangma added this to the Lumpy Space Princess milestone May 7, 2020
asangma added a commit that referenced this issue May 7, 2020
…ould use a hand getting filter to see element direction. (#959)
asangma added a commit that referenced this issue May 8, 2020
* Added RTL check in calite-filter. Updated related styles. @jcfranco could use a hand getting filter to see element direction. (#959)

* getElementDir for filter

Co-authored-by: Matt Driscoll <MDriscoll@esri.com>
@asangma asangma assigned kat10140 and unassigned asangma May 8, 2020
@asangma
Copy link
Contributor

asangma commented May 8, 2020

@kat10140 VERFS!

@kat10140
Copy link
Contributor

kat10140 commented May 8, 2020

ferfs!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - verified bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants