Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input-Date-Picker] valueAsDate array value not handled by watcher #10291

Closed
2 of 6 tasks
maxpatiiuk opened this issue Sep 12, 2024 · 5 comments
Closed
2 of 6 tasks

[Input-Date-Picker] valueAsDate array value not handled by watcher #10291

maxpatiiuk opened this issue Sep 12, 2024 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
Stalled

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Sep 12, 2024 •
edited by jcfranco
Loading

Check existing issues

Actual Behavior

The type of valueAsDate is Date | Date[].

However, the watcher here has wrong type:

calcite-design-system/packages/calcite-components/src/components/input-date-picker/input-date-picker.tsx

Lines 189 to 190 in 791fd78

valueAsDateWatcher(valueAsDate: Date): void {
this.datePickerActiveDate = valueAsDate;

this.datePickerActiveDate has type Date, so assigning Date[] to is is an error

Expected Behavior

Update the watcher to handle the Date | Date[] property type

Reproduction Sample

Reproduction Steps

Reproduction Version

2.13.0-next.9

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@maxpatiiuk maxpatiiuk added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 12, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 12, 2024
@jcfranco
Copy link
Member

Possibly handled by #8402. cc @anveshmekala

@geospatialem geospatialem mentioned this issue Sep 16, 2024
Closed
@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Sep 16, 2024
@geospatialem geospatialem added this to the Stalled milestone Sep 16, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Sep 16, 2024
anveshmekala added a commit that referenced this issue Sep 17, 2024
@anveshmekala
fix #10291
a1c540c
@anveshmekala
Copy link
Contributor

Possibly handled by #8402. cc @anveshmekala

Handled here

@anveshmekala anveshmekala self-assigned this Sep 18, 2024
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Sep 18, 2024
@anveshmekala anveshmekala mentioned this issue Oct 3, 2024
Merged
anveshmekala added a commit that referenced this issue Oct 23, 2024
@anveshmekala
feat(input-date-picker, date-picker): improve date picking experience (…
24d43ad 
…#8402)

**Related Issue:** #3455, #10113 

## Summary

Update `calcite-date-picker` & `calcite-input-date-picker` UI & UX.



![4D1CFC3C-8FF9-4493-9178-4DEDA0417031](https://github.com/user-attachments/assets/4b1f5a12-85df-4577-b1cd-812c22e41ef7)

### Key changes
- display two calendars for range irrespective of layout.
- No longer switches focus from day to end input when startDate is
selected initially.
- Month selection is possible via select menu
- No longer positions the date-picker component relative to endInput
when endInput is focused in range.
- Dates from previous months are not visible in range calendar.
- Divider indicator icons are removed in horizontal layout for range in
input-date-picker.
- No longer uses chevron icon which indicate the open status of
input-date-picker in startInput field.


Other issues resolved :
#6321
#6410
#10301
#10291
#10113
#10243
#10490

Blocked issues: #9167 

Wiki
https://github.com/Esri/calcite-design-system/wiki/date%E2%80%90picker-enhancement-%238402
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 23, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions GitHub Actions
Copy link
Contributor

Issue #3455 has been closed, this issue is ready for re-evaluation.

cc @geospatialem,@DitwanP

@github-actions github-actions bot removed the blocked This issue is blocked by another issue. label Oct 25, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Oct 29, 2024

This does not seem to be an issue any more, not getting any errors as described.

@DitwanP DitwanP closed this as completed Oct 29, 2024
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Oct 29, 2024
@DitwanP DitwanP reopened this Oct 29, 2024
@DitwanP DitwanP closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
Stalled
Development

No branches or pull requests
5 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP @anveshmekala