Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: add e2e helper for numberingSystem components #5646

Open
benelan opened this issue Oct 26, 2022 · 0 comments
Open

Test: add e2e helper for numberingSystem components #5646

benelan opened this issue Oct 26, 2022 · 0 comments
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Milestone
2024-07-30 - Jul ...

Comments

@benelan
Copy link
Member

benelan commented Oct 26, 2022

Test type

e2e helper

Which Component(s)

inputs, date-picker, time-picker, alert, stepper, pagination, slider

Unstable Tests

No response

Test error, if applicable

No response

PR skipped, if applicable

Additional Info

We could use an e2e test helper for numberingSystem components. Currently the NumberStringFormat class is tested thoroughly in the locale spec tests. And input, date-picker, and time-picker have good coverage because we can check their values. However, components like alert and stepper may be hard to test programically because the numbers are only UI elements. Stepper has snapshots, but Alert won't have any until we migrate to Chromatic since it needs interaction.

Stemmed from #5640 (review), cc @jcfranco
@benelan benelan added testing Issues related to automated or manual testing. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. labels Oct 26, 2022
@benelan benelan self-assigned this Oct 26, 2022
@benelan benelan added the Calcite (dev) Issues logged by Calcite developers. label Jan 30, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 30, 2023
@geospatialem geospatialem added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 3, 2024
@geospatialem geospatialem added estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 22, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Jan 29, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 29, 2024
jcfranco added a commit that referenced this issue Apr 16, 2024
@renovate @benelan @jcfranco
build(deps): update dependency @stencil/core to v4.16.0 (#9119)
75686b7 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@stencil/core](https://stenciljs.com/)
([source](https://togithub.com/ionic-team/stencil)) | [`4.13.0` ->
`4.15.0`](https://renovatebot.com/diffs/npm/@stencil%2fcore/4.13.0/4.15.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@stencil%2fcore/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@stencil%2fcore/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@stencil%2fcore/4.13.0/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@stencil%2fcore/4.13.0/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ionic-team/stencil (@&#8203;stencil/core)</summary>

### 

[`v4.16.0`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4150-2024-04-08)

[Compare 
Source](ionic-team/stencil@v4.15.0...v4.16.0)

##### Bug Fixes

* **cli:** fix a bug in CLI argument parsing
([#5646](ionic-team/stencil#5646))
([1fdea63](ionic-team/stencil@1fdea63)),
refs [#5640](ionic-team/stencil#5640)
* **testing:** prevent `find` from throwing error when query has no
match ([#5641](ionic-team/stencil#5641))
([b3886aa](ionic-team/stencil@b3886aa)),
closes [#5639](ionic-team/stencil#5639)

##### Features

* **dev-server:** dark mode support
([#5642](ionic-team/stencil#5642))
([89a5e40](ionic-team/stencil@89a5e40))
* **typescript:** Update dependency typescript to v5.4.5
([#5663](ionic-team/stencil#5663))
([2596536](ionic-team/stencil@2596536))

###

[`v4.15.0`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4150-2024-04-08)

[Compare

Source](https://togithub.com/ionic-team/stencil/compare/v4.14.1...v4.15.0)

##### Features

- **compiler:** perform automatic key insertion in more situations
([#&#8203;5594](https://togithub.com/ionic-team/stencil/issues/5594))

([8ee071b](https://togithub.com/ionic-team/stencil/commit/8ee071bf3aae4b2240b50f7af433035c8bf8aa49))
- **typescript:** Update dependency typescript to v5.4.4
([#&#8203;5636](https://togithub.com/ionic-team/stencil/issues/5636))

([a463871](https://togithub.com/ionic-team/stencil/commit/a46387123082d1af9fc17b5909530597dc5b5c68))

####

[`4.14.1`](https://togithub.com/ionic-team/stencil/compare/v4.14.0...v4.14.1)

##### Bug Fixes

- **compiler:** don't mistake aliased paths for collections imports
([#&#8203;5620](https://togithub.com/ionic-team/stencil/issues/5620))

([af22bb8](https://togithub.com/ionic-team/stencil/commit/af22bb858d64b60a97ce93c86f5585ef36b31c3f)),
closes
[#&#8203;2319](https://togithub.com/ionic-team/stencil/issues/2319)
- **runtime:** nested multiple default slot relocation
([#&#8203;5403](https://togithub.com/ionic-team/stencil/issues/5403))

([363c07b](https://togithub.com/ionic-team/stencil/commit/363c07b4723941954dc748189a744eec01d5b74c)),
partially closes
[#&#8203;5335](https://togithub.com/ionic-team/stencil/issues/5335)
- **runtime:** prevent ref callbacks from being called too early
([#&#8203;5614](https://togithub.com/ionic-team/stencil/issues/5614))

([81fa375](https://togithub.com/ionic-team/stencil/commit/81fa37587eb853d42bc7f92102318a3446cdea7b)),
closes
[#&#8203;4074](https://togithub.com/ionic-team/stencil/issues/4074)

###

[`v4.14.1`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4141-2024-04-04)

[Compare

Source](https://togithub.com/ionic-team/stencil/compare/v4.14.0...v4.14.1)

##### Bug Fixes

- **compiler:** don't mistake aliased paths for collections imports
([#&#8203;5620](https://togithub.com/ionic-team/stencil/issues/5620))

([af22bb8](https://togithub.com/ionic-team/stencil/commit/af22bb858d64b60a97ce93c86f5585ef36b31c3f)),
closes
[#&#8203;2319](https://togithub.com/ionic-team/stencil/issues/2319)
- **runtime:** nested multiple default slot relocation
([#&#8203;5403](https://togithub.com/ionic-team/stencil/issues/5403))

([363c07b](https://togithub.com/ionic-team/stencil/commit/363c07b4723941954dc748189a744eec01d5b74c)),
partially closes
[#&#8203;5335](https://togithub.com/ionic-team/stencil/issues/5335)
- **runtime:** prevent ref callbacks from being called too early
([#&#8203;5614](https://togithub.com/ionic-team/stencil/issues/5614))

([81fa375](https://togithub.com/ionic-team/stencil/commit/81fa37587eb853d42bc7f92102318a3446cdea7b)),
closes
[#&#8203;4074](https://togithub.com/ionic-team/stencil/issues/4074)

###

[`v4.14.0`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4140-2024-04-01)

[Compare

Source](https://togithub.com/ionic-team/stencil/compare/v4.13.0...v4.14.0)

##### Bug Fixes

- **mock-doc:** provide a local name
([#&#8203;5480](https://togithub.com/ionic-team/stencil/issues/5480))

([2f67b35](https://togithub.com/ionic-team/stencil/commit/2f67b3526c7160a0c9ac71727c401a438d282474)),
closes
[#&#8203;5342](https://togithub.com/ionic-team/stencil/issues/5342)
- **mock-doc:** resolve type issue for localName
([#&#8203;5595](https://togithub.com/ionic-team/stencil/issues/5595))

([d91af87](https://togithub.com/ionic-team/stencil/commit/d91af87d4e309a2da3cb145165cf7fe3c79ac1e7)),
closes
[#&#8203;5342](https://togithub.com/ionic-team/stencil/issues/5342)

##### Features

- **testing:** allow to set screenshot timeout option in Jest v28+
([#&#8203;5537](https://togithub.com/ionic-team/stencil/issues/5537))

([6df12b2](https://togithub.com/ionic-team/stencil/commit/6df12b2a445ffe431f8412758f298a6e1c8fe3ac))
- **testing:** support deep piercing with Puppeteer
([#&#8203;5481](https://togithub.com/ionic-team/stencil/issues/5481))

([13d5d41](https://togithub.com/ionic-team/stencil/commit/13d5d4188ac0d3d8d002ce93c4ec7abdde5c8086))
- **typescript:** Update dependency typescript to v5.4.3
([#&#8203;5588](https://togithub.com/ionic-team/stencil/issues/5588))

([9d489e4](https://togithub.com/ionic-team/stencil/commit/9d489e42a60391d2eb88cb0f7827a9368de18140))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone
America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Esri/calcite-design-system).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Co-authored-by: JC Franco <jfranco@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2024-07-30 - Jul Release
Development

No branches or pull requests
3 participants
@alisonailea @geospatialem @benelan