bug: E2EPage.find() throws error when using piercing selector targeting a non-existing element
#5639
Closed
3 tasks done
Assignees
Labels
Bug: Validated
This PR or Issue is verified to be a bug within Stencil
Comments
|
Hey @jcfranco Thanks for reporting this (again 😅). I've identified the issue and will have a PR up to fix this shortly! |
tanner-reits
added
Bug: Validated
tanner-reits
added a commit
that referenced
this issue
Apr 8, 2024
This commit fixes an issue w/ our Puppeteer testing implementation where the `find()` method would throw an error if the query had no matching elements. Fixes: #5639 STENCIL-1256
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 9, 2024
…tch (#5641) * fix(testing): prevent `find` from throwing error when query has no match This commit fixes an issue w/ our Puppeteer testing implementation where the `find()` method would throw an error if the query had no matching elements. Fixes: #5639 STENCIL-1256 * it likes this better * add non-shadow tests
|
@tanner-reits Thanks for the speedy fix! When is the next |
1 task
jcfranco
added a commit
to Esri/calcite-design-system
that referenced
this issue
Apr 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@stencil/core](https://stenciljs.com/) ([source](https://togithub.com/ionic-team/stencil)) | [`4.13.0` -> `4.15.0`](https://renovatebot.com/diffs/npm/@stencil%2fcore/4.13.0/4.15.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ionic-team/stencil (@​stencil/core)</summary> ### [`v4.16.0`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4150-2024-04-08) [Compare Source](ionic-team/stencil@v4.15.0...v4.16.0) ##### Bug Fixes * **cli:** fix a bug in CLI argument parsing ([#5646](ionic-team/stencil#5646)) ([1fdea63](ionic-team/stencil@1fdea63)), refs [#5640](ionic-team/stencil#5640) * **testing:** prevent `find` from throwing error when query has no match ([#5641](ionic-team/stencil#5641)) ([b3886aa](ionic-team/stencil@b3886aa)), closes [#5639](ionic-team/stencil#5639) ##### Features * **dev-server:** dark mode support ([#5642](ionic-team/stencil#5642)) ([89a5e40](ionic-team/stencil@89a5e40)) * **typescript:** Update dependency typescript to v5.4.5 ([#5663](ionic-team/stencil#5663)) ([2596536](ionic-team/stencil@2596536)) ### [`v4.15.0`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4150-2024-04-08) [Compare Source](https://togithub.com/ionic-team/stencil/compare/v4.14.1...v4.15.0) ##### Features - **compiler:** perform automatic key insertion in more situations ([#​5594](https://togithub.com/ionic-team/stencil/issues/5594)) ([8ee071b](https://togithub.com/ionic-team/stencil/commit/8ee071bf3aae4b2240b50f7af433035c8bf8aa49)) - **typescript:** Update dependency typescript to v5.4.4 ([#​5636](https://togithub.com/ionic-team/stencil/issues/5636)) ([a463871](https://togithub.com/ionic-team/stencil/commit/a46387123082d1af9fc17b5909530597dc5b5c68)) #### [`4.14.1`](https://togithub.com/ionic-team/stencil/compare/v4.14.0...v4.14.1) ##### Bug Fixes - **compiler:** don't mistake aliased paths for collections imports ([#​5620](https://togithub.com/ionic-team/stencil/issues/5620)) ([af22bb8](https://togithub.com/ionic-team/stencil/commit/af22bb858d64b60a97ce93c86f5585ef36b31c3f)), closes [#​2319](https://togithub.com/ionic-team/stencil/issues/2319) - **runtime:** nested multiple default slot relocation ([#​5403](https://togithub.com/ionic-team/stencil/issues/5403)) ([363c07b](https://togithub.com/ionic-team/stencil/commit/363c07b4723941954dc748189a744eec01d5b74c)), partially closes [#​5335](https://togithub.com/ionic-team/stencil/issues/5335) - **runtime:** prevent ref callbacks from being called too early ([#​5614](https://togithub.com/ionic-team/stencil/issues/5614)) ([81fa375](https://togithub.com/ionic-team/stencil/commit/81fa37587eb853d42bc7f92102318a3446cdea7b)), closes [#​4074](https://togithub.com/ionic-team/stencil/issues/4074) ### [`v4.14.1`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4141-2024-04-04) [Compare Source](https://togithub.com/ionic-team/stencil/compare/v4.14.0...v4.14.1) ##### Bug Fixes - **compiler:** don't mistake aliased paths for collections imports ([#​5620](https://togithub.com/ionic-team/stencil/issues/5620)) ([af22bb8](https://togithub.com/ionic-team/stencil/commit/af22bb858d64b60a97ce93c86f5585ef36b31c3f)), closes [#​2319](https://togithub.com/ionic-team/stencil/issues/2319) - **runtime:** nested multiple default slot relocation ([#​5403](https://togithub.com/ionic-team/stencil/issues/5403)) ([363c07b](https://togithub.com/ionic-team/stencil/commit/363c07b4723941954dc748189a744eec01d5b74c)), partially closes [#​5335](https://togithub.com/ionic-team/stencil/issues/5335) - **runtime:** prevent ref callbacks from being called too early ([#​5614](https://togithub.com/ionic-team/stencil/issues/5614)) ([81fa375](https://togithub.com/ionic-team/stencil/commit/81fa37587eb853d42bc7f92102318a3446cdea7b)), closes [#​4074](https://togithub.com/ionic-team/stencil/issues/4074) ### [`v4.14.0`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4140-2024-04-01) [Compare Source](https://togithub.com/ionic-team/stencil/compare/v4.13.0...v4.14.0) ##### Bug Fixes - **mock-doc:** provide a local name ([#​5480](https://togithub.com/ionic-team/stencil/issues/5480)) ([2f67b35](https://togithub.com/ionic-team/stencil/commit/2f67b3526c7160a0c9ac71727c401a438d282474)), closes [#​5342](https://togithub.com/ionic-team/stencil/issues/5342) - **mock-doc:** resolve type issue for localName ([#​5595](https://togithub.com/ionic-team/stencil/issues/5595)) ([d91af87](https://togithub.com/ionic-team/stencil/commit/d91af87d4e309a2da3cb145165cf7fe3c79ac1e7)), closes [#​5342](https://togithub.com/ionic-team/stencil/issues/5342) ##### Features - **testing:** allow to set screenshot timeout option in Jest v28+ ([#​5537](https://togithub.com/ionic-team/stencil/issues/5537)) ([6df12b2](https://togithub.com/ionic-team/stencil/commit/6df12b2a445ffe431f8412758f298a6e1c8fe3ac)) - **testing:** support deep piercing with Puppeteer ([#​5481](https://togithub.com/ionic-team/stencil/issues/5481)) ([13d5d41](https://togithub.com/ionic-team/stencil/commit/13d5d4188ac0d3d8d002ce93c4ec7abdde5c8086)) - **typescript:** Update dependency typescript to v5.4.3 ([#​5588](https://togithub.com/ionic-team/stencil/issues/5588)) ([9d489e4](https://togithub.com/ionic-team/stencil/commit/9d489e42a60391d2eb88cb0f7827a9368de18140)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Esri/calcite-design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <no-reply@benelan.dev> Co-authored-by: JC Franco <jfranco@esri.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Stencil Version
4.14.0
Current Behavior
Calling
findwith a piercing selector where the target does not exist throws an error instead of returningnullas the doc states.Expected Behavior
For
find()to returnnullfor shadow DOM elements that are not found.System Info
System: node 20.10.0 Platform: darwin (23.3.0) CPU Model: Apple M1 Pro (10 cpus) Compiler: /Users/juan6600/dev/projects/stencil-4.14.0-breaks-piercing-selector-for-non-existent-elements/node_modules/@stencil/core/compiler/stencil.js Build: 1711981251 Stencil: 4.14.0 🚡 TypeScript: 5.4.3 Rollup: 2.56.3 Parse5: 7.1.2 jQuery: 4.0.0-pre Terser: 5.30.0Steps to Reproduce
See repro case readme.
Code Reproduction URL
https://github.com/jcfranco/stencil-4.14.0-breaks-piercing-selector-for-non-existent-elements
Additional Information
4.13.0 does not throw an error and works as expected.
This was previously fixed for another version in #5113.
The text was updated successfully, but these errors were encountered: