-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input-time): calcite-input-time component #5639
Open
eriklharper
wants to merge
71
commits into
main
Choose a base branch
from
eriklharper/2709-input-time
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,075
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-components into eriklharper/2709-input-time
…special delimiter characters are displayed
… and change it to take an emit argument instead. Also need to refactor setValuePart to keep from emitting on changes that don't affect full this.value changes
…lso removing redundant change emit
…lharper/2709-input-time
…fixes so that those values can always be displayed regardless if the time value is set or not.
…lharper/2709-input-time
…lharper/2709-input-time
…-components into eriklharper/2709-input-time
…lharper/2709-input-time
github-actions
bot
added
the
enhancement
Issues tied to a new feature or request.
label
Oct 25, 2022
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Issues or pull requests that have not had recent activity.
label
Nov 3, 2022
…lharper/2709-input-time
…mo page to match existing input-time-picker setup
…klharper/2709-input-time
…klharper/2709-input-time
eriklharper
requested review from
jcfranco,
driskull and
geospatialem
as code owners
September 8, 2023 18:11
…ional seconds, which we'll add later
…e emitting change events in real time as the value is changing now
…klharper/2709-input-time
…klharper/2709-input-time
…klharper/2709-input-time
jcfranco
added a commit
that referenced
this pull request
Apr 16, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@stencil/core](https://stenciljs.com/) ([source](https://togithub.com/ionic-team/stencil)) | [`4.13.0` -> `4.15.0`](https://renovatebot.com/diffs/npm/@stencil%2fcore/4.13.0/4.15.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@stencil%2fcore/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@stencil%2fcore/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@stencil%2fcore/4.13.0/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@stencil%2fcore/4.13.0/4.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ionic-team/stencil (@​stencil/core)</summary> ### [`v4.16.0`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4150-2024-04-08) [Compare Source](ionic-team/stencil@v4.15.0...v4.16.0) ##### Bug Fixes * **cli:** fix a bug in CLI argument parsing ([#5646](ionic-team/stencil#5646)) ([1fdea63](ionic-team/stencil@1fdea63)), refs [#5640](ionic-team/stencil#5640) * **testing:** prevent `find` from throwing error when query has no match ([#5641](ionic-team/stencil#5641)) ([b3886aa](ionic-team/stencil@b3886aa)), closes [#5639](ionic-team/stencil#5639) ##### Features * **dev-server:** dark mode support ([#5642](ionic-team/stencil#5642)) ([89a5e40](ionic-team/stencil@89a5e40)) * **typescript:** Update dependency typescript to v5.4.5 ([#5663](ionic-team/stencil#5663)) ([2596536](ionic-team/stencil@2596536)) ### [`v4.15.0`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4150-2024-04-08) [Compare Source](https://togithub.com/ionic-team/stencil/compare/v4.14.1...v4.15.0) ##### Features - **compiler:** perform automatic key insertion in more situations ([#​5594](https://togithub.com/ionic-team/stencil/issues/5594)) ([8ee071b](https://togithub.com/ionic-team/stencil/commit/8ee071bf3aae4b2240b50f7af433035c8bf8aa49)) - **typescript:** Update dependency typescript to v5.4.4 ([#​5636](https://togithub.com/ionic-team/stencil/issues/5636)) ([a463871](https://togithub.com/ionic-team/stencil/commit/a46387123082d1af9fc17b5909530597dc5b5c68)) #### [`4.14.1`](https://togithub.com/ionic-team/stencil/compare/v4.14.0...v4.14.1) ##### Bug Fixes - **compiler:** don't mistake aliased paths for collections imports ([#​5620](https://togithub.com/ionic-team/stencil/issues/5620)) ([af22bb8](https://togithub.com/ionic-team/stencil/commit/af22bb858d64b60a97ce93c86f5585ef36b31c3f)), closes [#​2319](https://togithub.com/ionic-team/stencil/issues/2319) - **runtime:** nested multiple default slot relocation ([#​5403](https://togithub.com/ionic-team/stencil/issues/5403)) ([363c07b](https://togithub.com/ionic-team/stencil/commit/363c07b4723941954dc748189a744eec01d5b74c)), partially closes [#​5335](https://togithub.com/ionic-team/stencil/issues/5335) - **runtime:** prevent ref callbacks from being called too early ([#​5614](https://togithub.com/ionic-team/stencil/issues/5614)) ([81fa375](https://togithub.com/ionic-team/stencil/commit/81fa37587eb853d42bc7f92102318a3446cdea7b)), closes [#​4074](https://togithub.com/ionic-team/stencil/issues/4074) ### [`v4.14.1`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4141-2024-04-04) [Compare Source](https://togithub.com/ionic-team/stencil/compare/v4.14.0...v4.14.1) ##### Bug Fixes - **compiler:** don't mistake aliased paths for collections imports ([#​5620](https://togithub.com/ionic-team/stencil/issues/5620)) ([af22bb8](https://togithub.com/ionic-team/stencil/commit/af22bb858d64b60a97ce93c86f5585ef36b31c3f)), closes [#​2319](https://togithub.com/ionic-team/stencil/issues/2319) - **runtime:** nested multiple default slot relocation ([#​5403](https://togithub.com/ionic-team/stencil/issues/5403)) ([363c07b](https://togithub.com/ionic-team/stencil/commit/363c07b4723941954dc748189a744eec01d5b74c)), partially closes [#​5335](https://togithub.com/ionic-team/stencil/issues/5335) - **runtime:** prevent ref callbacks from being called too early ([#​5614](https://togithub.com/ionic-team/stencil/issues/5614)) ([81fa375](https://togithub.com/ionic-team/stencil/commit/81fa37587eb853d42bc7f92102318a3446cdea7b)), closes [#​4074](https://togithub.com/ionic-team/stencil/issues/4074) ### [`v4.14.0`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4140-2024-04-01) [Compare Source](https://togithub.com/ionic-team/stencil/compare/v4.13.0...v4.14.0) ##### Bug Fixes - **mock-doc:** provide a local name ([#​5480](https://togithub.com/ionic-team/stencil/issues/5480)) ([2f67b35](https://togithub.com/ionic-team/stencil/commit/2f67b3526c7160a0c9ac71727c401a438d282474)), closes [#​5342](https://togithub.com/ionic-team/stencil/issues/5342) - **mock-doc:** resolve type issue for localName ([#​5595](https://togithub.com/ionic-team/stencil/issues/5595)) ([d91af87](https://togithub.com/ionic-team/stencil/commit/d91af87d4e309a2da3cb145165cf7fe3c79ac1e7)), closes [#​5342](https://togithub.com/ionic-team/stencil/issues/5342) ##### Features - **testing:** allow to set screenshot timeout option in Jest v28+ ([#​5537](https://togithub.com/ionic-team/stencil/issues/5537)) ([6df12b2](https://togithub.com/ionic-team/stencil/commit/6df12b2a445ffe431f8412758f298a6e1c8fe3ac)) - **testing:** support deep piercing with Puppeteer ([#​5481](https://togithub.com/ionic-team/stencil/issues/5481)) ([13d5d41](https://togithub.com/ionic-team/stencil/commit/13d5d4188ac0d3d8d002ce93c4ec7abdde5c8086)) - **typescript:** Update dependency typescript to v5.4.3 ([#​5588](https://togithub.com/ionic-team/stencil/issues/5588)) ([9d489e4](https://togithub.com/ionic-team/stencil/commit/9d489e42a60391d2eb88cb0f7827a9368de18140)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Esri/calcite-design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <no-reply@benelan.dev> Co-authored-by: JC Franco <jfranco@esri.com>
github-actions
bot
removed
the
Stale
Issues or pull requests that have not had recent activity.
label
May 27, 2024
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Issues or pull requests that have not had recent activity.
label
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Calcite (dev)
Issues logged by Calcite developers.
enhancement
Issues tied to a new feature or request.
Stale
Issues or pull requests that have not had recent activity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #2709
Summary
Introduces the new
calcite-input-time
component for simplified time entry.