Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list-item): hide nested list items by default #9474

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

driskull
Copy link
Member

Related Issue: #9400

Summary

  • Hides nested/indented list items by default
  • Removes unnecessary div

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 30, 2024
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 30, 2024
@driskull driskull marked this pull request as ready for review May 31, 2024 16:21
@driskull driskull requested a review from a team as a code owner May 31, 2024 16:21
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplification! 🎉

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 📝

There doesn't seem to be any reported diffs in the Chromatic build. If missing, can you add a screenshot test?

@driskull
Copy link
Member Author

driskull commented Jun 6, 2024

There doesn't seem to be any reported diffs in the Chromatic build. If missing, can you add a screenshot test?

I don't think a screenshot test would cover this. Its basically a flash of content.

@jcfranco
Copy link
Member

jcfranco commented Jun 6, 2024

Gotcha. Thanks for clarifying!

@driskull driskull merged commit fb06ef9 into main Jun 6, 2024
10 checks passed
@driskull driskull deleted the dris0000/list-item-flash-fix branch June 6, 2024 21:03
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 6, 2024
benelan added a commit that referenced this pull request Jun 10, 2024
…orkflow

* origin/main: (26 commits)
  revert: refactor: add simpler `componentFocusable` util (deprecates `LoadableComponent`) (#9515)
  chore(linting): enable selector-pseudo-element-colon-notation rule (#9518)
  refactor(storybook): refactor tooltip simple story interface (#9538)
  refactor(dom): consolidate transition/animation waiting utils (#9341)
  refactor(storybook): build storybook simple story args interfaces using component class (#9457)
  chore: release next
  fix(block): add accessible label for slotted controls (#9502)
  feat(action-bar, action-pad): add expandLabel and collapseLabel to messages (#9497)
  chore: release next
  feat(action-menu, combobox, dropdown, input-date-picker, popover): allow logical placements for flipPlacements property. #8825 (#9490)
  fix(popover): correct border radius on close button (#9485)
  fix(list-item): hide nested list items by default (#9474)
  refactor: move component types into component specific interfaces files (#9527)
  chore: release next
  fix(alert): pause auto-close alert when link focused (#9503)
  refactor(storybook): consolidate storybook and component types (#9500)
  refactor(calcite-block-section,calcite-card): consolidate interfaces imports (#9517)
  chore: release next
  fix(block-section): restore block toggling when clicking on the header switch (#9472)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants