-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(color): add color component #592
Conversation
calcite-color-picker
The only outstanding item now is what to do with the small scale layout (see previous comment ☝️). |
For now, in small scale we could just drop the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commentz
src/components/calcite-color-hex-input/calcite-color-hex-input.tsx
Outdated
Show resolved
Hide resolved
ok @jcfranco here we go again... sorry for the back and forth and universal sadness throughout this component. But... here's the latest. Provided some spacing specs too. (all the typography is 14px) any questions please let me know |
@jcfranco @macandcheese @julio8a This is getting really confusing since we already have calcite-colors as a library. Let's change the name back to calcite-color-picker |
|
If you are using the scale system the graph height on M and L is slightly off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship ittttt
Issue #64
This adds the following components:
calcite-color
calcite-color-hex-input
calcite-color-swatch
API
Pending
intlProp
?).Notes
rgb()
, it will remainrgb()
after making updates).color
prop is available for advanced color use casestsconfig.json
.Questions
#007AC2
.calcite-date
, should this be renamed tocalcite-color
?