docs(tile, tile-group): deprecate components #9302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dit13711/depricate-tile-select-component
geospatialem
reviewed
May 9, 2024
There was a problem hiding this comment.
Awesome! We'll need to tag team on the naming convention, as #9285 uses calcite- and this is PR currently scoped to the component name.
WDYT is the best approach?
I don't think it makes a huge difference but if we are to make a decision going forward I prefer the "calcite-..." option. |
…into dit13711/depricate-tile-select-component
geospatialem
approved these changes
May 13, 2024
packages/calcite-components/src/components/tile-select-group/tile-select-group.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/tile-select/tile-select.tsx
Outdated
Show resolved
Hide resolved
…into dit13711/depricate-tile-select-component
geospatialem
approved these changes
May 13, 2024
…into dit13711/depricate-tile-select-component
…into dit13711/depricate-tile-select-component
…into dit13711/depricate-tile-select-component
DitwanP
added
the
skip visual snapshots
DitwanP
added a commit
that referenced
this pull request
May 13, 2024
…tem): use "calcite-" naming convention in deprecation descriptions (#9312) **Related Issue:** [Comment that suggests having a consistent convention.](#9302 (review)) ## Summary Changes the component names to use "calcite-" naming convention in deprecation descriptions for the following components: - `pick-list` - `pick-list-group` - `pick-list-item` - `value-list` - `value-list-item`
geospatialem
modified the milestones:
2024-05-14 - May maintenance release,
2024-05-28 - May Main Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9253
Summary
Adds a JSDoc
@deprecatedtag to the following components:tile-selecttile-select-group