Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1021 - Dropdowns #1071

Merged
merged 3 commits into from
Apr 1, 2019
Merged

#1021 - Dropdowns #1071

merged 3 commits into from
Apr 1, 2019

Conversation

macandcheese
Copy link
Contributor

PR for #1021.

This builds on Julio's work to update the style of dropdown menus - there are no structural changes. Tested in Chrome, FF, Safari, Edge. Waiting for #1070 to test in IE 11.

Changes:

  • These should now match Online / discussed updates
  • Hit areas for dropdown links are now full width, and have distinct hover / focus states
  • Introduces an active-link-dot mixin to use in future designs
  • Uses shadow level / strength from Alerts (#1023 - Alerts #1068)
  • Uses invocation animation from Online

Questions / Need feedback on:

  • Is using content: "\2022" for the pseudo-element active dot sustainable? It makes aligning the active dot with the line-height easy but unsure if there are consequences with translation of the character. Alternatively we can use a bg-color in the pseudo-element.
  • I think the current 600 weight items (header, active item) are good candidates for 500 weight treatment.

Copy link
Contributor

@julio8a julio8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'm not sure about the sustainability of the pseudo-element, @paulcpederson might have a better idea here.
  • Good idea on weight change for titles and active. Worth taking a look once we have 500 in.

@macandcheese
Copy link
Contributor Author

Updates based on last week's feedback...

  • Indent link items, align "active dot" flush left with heading
  • remove font-weight adjustment for active state
  • small color and padding adjustments

We can use this as the base for filters, side navs, etc

@macandcheese macandcheese merged commit 03b5dab into Esri:2.0 Apr 1, 2019
@macandcheese macandcheese deleted the feature/2.0dropdown branch April 1, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants