Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in the ReadMe section "Deploying". Build instruction does not match any command defined in package.json #8

Open
fabanc opened this issue May 1, 2019 · 0 comments

Comments

@fabanc
Copy link

fabanc commented May 1, 2019

Step 2 of the deployment instructions states the following:

Install npm and run npm install via command line then run npm run build.

The only commands define for run in package.json are the following:

  "scripts": {
    "start": "npm-run-all --parallel watch:sass watch:ts",
    "copy:node_modules": "./node_modules/.bin/cpx './node_modules/@esri/**/*.js' app",
    "watch:ts": "tsc --watch",
    "build:ts": "tsc",
    "build:sass": "./node_modules/.bin/node-sass styles/main.scss styles/main.css",
    "watch:sass": "./node_modules/.bin/node-sass --watch styles/main.scss styles/main.css",
    "deploy": "npm run build:sass & npm run build:ts & npm run copy:node_modules"
  },

Is that safe to assume that the command to run should be npm run deploy, which run all the build commands?

fabanc pushed a commit to fabanc/compare-app that referenced this issue May 1, 2019
fabanc pushed a commit to fabanc/compare-app that referenced this issue May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant