Maintaining module names, official typings file support

[nickcam]

Added an option 'maintainModuleNames' that if set to true will register each esri module into it's own module in systemjs. This plays well with the official typings file when importing into classes.

Made the name 'default' so a default import syntax should be used. Seems to actually work across module systems that may be defined in tsconfig, ie: system, commonjs, amd...etc.

In Visual Studio using the official typings I was getting a compilation error using any type other than 'system' though. Have a feeling other IDE's may be more forgiving...haven't tested in others though.

Thanks,
Nick

[tomwayson]

Thanks @nickcam!

I'll test this week w/ other IDEs with the intent to merge.

[tomwayson]

Ultimately this probably needs to check for the other Dojo packages like 'dijit', 'dojox', etc, right? I'm still not totally clear how this works (I'll have to do some console.loging so I can see what's going on, but the main thing is, it works!

[tomwayson]

@nickcam this is awesome! I got it working in @jwasilgeo's angular2-esri-playground app by setting maintainModuleNames: true and updating all the import statements to import defaults using the full module names like so:

import Map from 'esri/Map';
import MapView from 'esri/views/MapView';

I then ran the following to get the typings:

typings install --global --save github:Esri/jsapi-resources/4.x/typescript/arcgis-js-api.d.ts

And now I have intellisense for the ArcGIS API for JavaScript, which is pretty fucking amazing

This works well, and is much more straightforward than registering all the modules off a single psuedo module (like esri-mods). In fact, w/ the typings support, it's hard to imagine a reason why anyone would want to do it the other way. So, I'd like this to be the default way this library behaves. I'm thinking of doing away w/ the maintainModuleNames option, and only calling registerToOutModule if the outModuleName option is passed. That would be a breaking change, so I'll release that as v1.0.0-beta.0.

Once I've done that, I'll make a PR to angular2-esri-playground that uses the new API.

[nickcam]

Ok cool, glad it's working - yeah it's ridiculously helpful having intellisense isn't it!

Regarding your comment, yep you'll have to add dijit and dojox to the check for module names, not adding dojox bit me the other day until I realised what was going on :).

I think it's a good idea to make it the default behavior as well, just seems a little more standard.

[jwasilgeo]

Wow. This is awesome!