Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use component logger on Paper for console colors #4941

Merged
merged 10 commits into from
Jun 27, 2022
Merged

Use component logger on Paper for console colors #4941

merged 10 commits into from
Jun 27, 2022

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Jun 14, 2022

Fixes #4895

@JRoy JRoy added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module module: discord Issues or PRs for the EssentialsDiscord module module: chat Issues or PRs for the EssentialsChat module module: spawn Issues or PRs for the EssentialsSpawn module module: geo Issues or PRs for the EssentialsGeo module module: protect Issues or PRs for the EssentialsProtect module labels Jun 14, 2022
@JRoy JRoy added this to the 2.19.5 milestone Jun 14, 2022
mdcfe
mdcfe previously requested changes Jun 15, 2022
View reviewed changes
Copy link
Member

@mdcfe mdcfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not a fan of replacing every single usage of a logger with a static method.

@JRoy JRoy requested a review from mdcfe June 17, 2022 20:59
@mdcfe mdcfe mentioned this pull request Jun 26, 2022
Closed
@mdcfe mdcfe changed the title Add providers for paper component logging Use component logger on Paper for console colors Jun 27, 2022
@JRoy JRoy merged commit 6816eb4 into EssentialsX:2.x Jun 27, 2022
@JRoy JRoy deleted the stupid-fucking-colors branch June 27, 2022 18:54
@mdcfe mdcfe mentioned this pull request Aug 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdcfe mdcfe mdcfe approved these changes

Assignees
No one assigned
Labels
module: chat Issues or PRs for the EssentialsChat module module: discord Issues or PRs for the EssentialsDiscord module module: geo Issues or PRs for the EssentialsGeo module module: main Issues or PRs for the main Essentials module module: protect Issues or PRs for the EssentialsProtect module module: spawn Issues or PRs for the EssentialsSpawn module type: enhancement Features and feature requests.
Projects
None yet
Milestone
2.19.5
Development

Successfully merging this pull request may close these issues.

Paper console colors are broken
2 participants
@JRoy @mdcfe