Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minecraft namespace not working in give command #4960

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Fix minecraft namespace not working in give command #4960

merged 1 commit into from
Jun 25, 2022

Conversation

t-hermanns
Copy link
Contributor

@t-hermanns t-hermanns commented Jun 25, 2022 •
edited
Loading

Information

This PR fixes #4946.

Details

Proposed fix:

Modified regex of split in FlatItemDb.java to not split the : if there is a preceding "minecraft" that starts at the beginning of the line.

Environments tested:

OS: Windows 11

Java version: 17.0.1

  • Most recent Paper version (1.19, git-Paper-36)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

Before:
grafik

After:
grafik

@t-hermanns
changed item name colon split
6e071eb 
now does not split 'minecraft:' at start of line
@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Jun 25, 2022
@JRoy JRoy changed the title Fix Give Command Error on preceding 'minecraft:' Fix minecraft namespace not working in give command Jun 25, 2022
@JRoy JRoy merged commit 9c5536b into EssentialsX:2.x Jun 25, 2022
@JRoy
Copy link
Member

JRoy commented Jun 25, 2022

Thanks for the contribution!

@t-hermanns t-hermanns deleted the give-com-minecraft-prefix branch June 25, 2022 21:47
@mdcfe mdcfe added this to the 2.19.5 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRoy JRoy JRoy approved these changes

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Milestone
2.19.5
Development

Successfully merging this pull request may close these issues.

Give command doesn't support minecraft namespace
3 participants
@t-hermanns @JRoy @mdcfe