Auto set current year and season quarter in event results #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XanderRiga
force-pushed
the
xriga/set-season-year-and-quarter
branch
from
81b14ce
to
1779a8e
Compare
The year is easy enough to make current, but the quarter is a bit more work, so we will let the user supply it for now while we find an effective way to get the current quarter without making extra network calls. This also moves the `datetime_from_iracing_timestamp` to outside of chart data, this converts unix timestamps from ms to datetimes and we will be using this in more places than just the chart data objects.
XanderRiga
force-pushed
the
xriga/set-season-year-and-quarter
branch
from
1779a8e
to
4a80ba1
Compare
Esterni
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't be exact as seasons can sometimes run over by a week or
under, but generally iracing follows this scheme that they do 3 month
seasons starting in January.