Bugfixes and cleanup #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found other calls of stats_chart and fixed the attributes order in them, too. |
XanderRiga
reviewed
Jul 23, 2020
XanderRiga
reviewed
Jul 23, 2020
XanderRiga
reviewed
Jul 23, 2020
|
Good catch on the stats chart stuff, that's a bad miss by us. Just a few small comments then I will approve |
XanderRiga
reviewed
Jul 23, 2020
NoHeDidnt
commented
Jul 23, 2020
|
Sorry, didn't mean to close before. |
Co-authored-by: NoHeDidn't <dj@nohedidnt.de>
Co-authored-by: NoHeDidn't <dj@nohedidnt.de>
Co-authored-by: NoHeDidn't <dj@nohedidnt.de>
Co-authored-by: NoHeDidn't <dj@nohedidnt.de>
Co-authored-by: NoHeDidn't <dj@nohedidnt.de>
Esterni
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor stuff I found. I left a comment on each commit to explain, hopefully. Haven't had much time to play around a bit more, yet.