Fixes passing through a custom logger #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the level of some log messages
…d the level of some log messages
|
As per the discussion with @mikeholler I think we decided this was not necessary. He can maybe confirm as he has a better understanding, but it sounds like we can just make and use a logger directly and then the parent application can add their own handler to the logger if they like |
…into Useful-logging
|
Fixed in #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is being made with the understanding that logging will be further changed in the future. This checks to see if the user provided a custom logger before instantiating one and will provide custom logging until we implement best practices.
A couple log entries were modified to bring log messages in line with logging.info providing status checks that things are working normally and logging.debug providing detailed information.