Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Caps allowed file extensions #810

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

Badatos
Copy link
Collaborator

@Badatos Badatos commented Apr 13, 2023

When "jpg" is set as an allowed extension, "JPG" will by allowed too.

@Badatos Badatos changed the title Caps allowed file extensions [DONE] Caps allowed file extensions Apr 13, 2023
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi mais il faudrait préciser dans le fichier configuration.json que les valeurs possibles pour les extensions doivent être en minuscule https://github.com/EsupPortail/Esup-Pod/blob/master/pod/main/configuration.json#L1528

@Badatos
Copy link
Collaborator Author

Badatos commented Apr 13, 2023

ok pour moi mais il faudrait préciser dans le fichier configuration.json que les valeurs possibles pour les extensions doivent être en minuscule https://github.com/EsupPortail/Esup-Pod/blob/master/pod/main/configuration.json#L1528

C'est fait ;)

Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi, c'est parfait merci

@ptitloup ptitloup merged commit 2ad6ac5 into EsupPortail:develop Apr 14, 2023
@Badatos Badatos deleted the caps-allowed-extensions branch April 14, 2023 09:42
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Apr 20, 2023
* Allow CAPS in IMAGE_ALLOWED_EXTENSIONS and FILE_ALLOWED_EXTENSIONS

* precise in configuration.json that extensions must be lowercase
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Apr 26, 2023
* Allow CAPS in IMAGE_ALLOWED_EXTENSIONS and FILE_ALLOWED_EXTENSIONS

* precise in configuration.json that extensions must be lowercase
@Badatos Badatos self-assigned this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants