Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve branch name extraction #5

Closed
wants to merge 4 commits into from
Closed

Improve branch name extraction #5

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2021

Remove refs/.../ prefix and /merge suffix wherever they apper.
Now supports slashes!

@ghost ghost closed this May 8, 2022
@EthanSK
Copy link
Owner

EthanSK commented May 9, 2022

why did you close it? sorry I didn't get to it. I can merge it if it works.

@ghost
Copy link
Author

ghost commented May 10, 2022

Change in philosophy. The merge commit is a positive thing in CI (testing the PR after merge >>> testing before merge)

Some people prefer to always rebase (small project!) & don't need to use the merged ref as much

I am more against than for now.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant