Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix msa file upload #5546

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Fix msa file upload #5546

merged 2 commits into from
Mar 23, 2022

Conversation

indrajitsinh
Copy link

@indrajitsinh indrajitsinh commented Mar 23, 2022

Summary

A summary of changes being made in this PR

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@barankyle
Copy link
Member

@indrajitsinh Is this ready to be merged in? It's still marked as a draft.

@indrajitsinh
Copy link
Author

@barankyle yup, can be merged

@indrajitsinh indrajitsinh marked this pull request as ready for review March 23, 2022 17:23
@barankyle barankyle merged commit 60fa123 into dev Mar 23, 2022
@barankyle barankyle deleted the fix-msa-file-upload branch March 23, 2022 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants