Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ecdsa-sha2-nistp{256,384,521} #267

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Implement ecdsa-sha2-nistp{256,384,521} #267

merged 2 commits into from
Apr 22, 2024

Conversation

robertabcd
Copy link
Contributor

  • Moved ECDSA into ec module.
  • Added support and tests for these algorithms.

Ported and cleaned up from a different fork of thrussh by me.

@robertabcd
Implement ecdsa-sha2-nistp{256,384,521}
8244f4b 
* Moved ECDSA into `ec` module.
* Added support and tests for these algorithms.
@robertabcd
Copy link
Contributor Author

Update:

  • Addressed code format
  • Manually allowed clippy for RSA (to be consistent with Signature::RSA)

@robertabcd robertabcd mentioned this pull request Apr 22, 2024
Closed
@Eugeny
Copy link
Owner

Eugeny commented Apr 22, 2024

Thank you! Looks good so far with a few additions from my side

@Eugeny Eugeny merged commit 3041b0c into Eugeny:main Apr 22, 2024
4 checks passed
@robertabcd robertabcd mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertabcd @Eugeny