Fixing Drawer click behavior #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devzgabriel
approved these changes
Dec 31, 2021
SampaioLeal
pushed a commit
that referenced
this pull request
Jan 14, 2022
* chore: updating mui * fix: drawer onClick behavior
devzgabriel
added a commit
that referenced
this pull request
Jan 14, 2022
* Fix/export types (#21) * 0.0.2 (#20) * add readme * fix: removing dependencies from bundle (#2) * add dependencies instalation on readme * Storybook config and first stories * feat: add readme (#1) * add readme * add dependencies instalation on readme * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * chore: resolvingconversations * chore: resolve conversations Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * chore: initial config * chore: romove not necessary configs * Docs/code of conduct (#6) * add code of conduct * chore: add Breadcrumbs and Dialog tests Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * wip: snackbar tests * done: snackbar tests * chore: tests on workflow * chore: tests on workflow * chore: slobe CI problem * chore: add jsDocs * refactoring tests * fix import bugs * resolve conversations * remove warnigs * Update README.md Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> * add AppBar Components and Store * remove mui icons from dependencies * add dependencies on readme and workflow * ESBuild implemented (#16) * added esbuild * chore: solve CI Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> * chore: improve tests * upgrade dependencies * chore: upgrade dependencies * chore: add drawer attribute in Page type * lint: solve unused code Co-authored-by: Sampaio Leal <samp14hd@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * fix: folder structure of exports with cjs by default Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * fix: package files field removed * chore: added ramda to deps * chore: exporting esm by default * fix: using enum for bindings * 0.1.2 * Fixing Drawer click behavior (#23) * chore: updating mui * fix: drawer onClick behavior * Fixing tests and behaviors (#24) * chore: updating mui * fix: drawer onClick behavior * fix: tests and components behavior * chore: removing comment * feat: hiding drawer pages (#27) * Fix/esbuild-path-alias (#26) * fix: typescript path alias with esbuild * chore: decorating uistore without decorators * Fix/breadcrumb-links (#25) * fix: breadcrumbs now have onClick function * fix: breadcrumb tests * Fix/disabled-draweritem (#28) * feat: hiding drawer pages * fix: hiding drawer items logic * Update AppBar.stories.tsx Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com>
devzgabriel
added a commit
that referenced
this pull request
Jan 14, 2022
* Fix/export types (#21) * 0.0.2 (#20) * add readme * fix: removing dependencies from bundle (#2) * add dependencies instalation on readme * Storybook config and first stories * feat: add readme (#1) * add readme * add dependencies instalation on readme * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * chore: resolvingconversations * chore: resolve conversations Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * chore: initial config * chore: romove not necessary configs * Docs/code of conduct (#6) * add code of conduct * chore: add Breadcrumbs and Dialog tests Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * wip: snackbar tests * done: snackbar tests * chore: tests on workflow * chore: tests on workflow * chore: slobe CI problem * chore: add jsDocs * refactoring tests * fix import bugs * resolve conversations * remove warnigs * Update README.md Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> * add AppBar Components and Store * remove mui icons from dependencies * add dependencies on readme and workflow * ESBuild implemented (#16) * added esbuild * chore: solve CI Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> * chore: improve tests * upgrade dependencies * chore: upgrade dependencies * chore: add drawer attribute in Page type * lint: solve unused code Co-authored-by: Sampaio Leal <samp14hd@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * fix: folder structure of exports with cjs by default Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * chore: exporting esm by default * Fixing Drawer click behavior (#23) * chore: updating mui * fix: drawer onClick behavior * Fixing tests and behaviors (#24) * chore: updating mui * fix: drawer onClick behavior * fix: tests and components behavior * chore: removing comment * feat: hiding drawer pages (#27) * Fix/esbuild-path-alias (#26) * fix: typescript path alias with esbuild * chore: decorating uistore without decorators * Fix/breadcrumb-links (#25) * fix: breadcrumbs now have onClick function * fix: breadcrumb tests * 0.2.0 Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com>
devzgabriel
added a commit
that referenced
this pull request
Jan 14, 2022
* Fix/export types (#21) * 0.0.2 (#20) * add readme * fix: removing dependencies from bundle (#2) * add dependencies instalation on readme * Storybook config and first stories * feat: add readme (#1) * add readme * add dependencies instalation on readme * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * chore: resolvingconversations * chore: resolve conversations Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * chore: initial config * chore: romove not necessary configs * Docs/code of conduct (#6) * add code of conduct * chore: add Breadcrumbs and Dialog tests Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * wip: snackbar tests * done: snackbar tests * chore: tests on workflow * chore: tests on workflow * chore: slobe CI problem * chore: add jsDocs * refactoring tests * fix import bugs * resolve conversations * remove warnigs * Update README.md Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> * add AppBar Components and Store * remove mui icons from dependencies * add dependencies on readme and workflow * ESBuild implemented (#16) * added esbuild * chore: solve CI Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> * chore: improve tests * upgrade dependencies * chore: upgrade dependencies * chore: add drawer attribute in Page type * lint: solve unused code Co-authored-by: Sampaio Leal <samp14hd@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * fix: folder structure of exports with cjs by default Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * fix: package files field removed * chore: added ramda to deps * chore: exporting esm by default * fix: using enum for bindings * 0.1.2 * Fixing Drawer click behavior (#23) * chore: updating mui * fix: drawer onClick behavior * Fixing tests and behaviors (#24) * chore: updating mui * fix: drawer onClick behavior * fix: tests and components behavior * chore: removing comment * feat: hiding drawer pages (#27) * Fix/esbuild-path-alias (#26) * fix: typescript path alias with esbuild * chore: decorating uistore without decorators * Fix/breadcrumb-links (#25) * fix: breadcrumbs now have onClick function * fix: breadcrumb tests * Fix/disabled-draweritem (#28) * feat: hiding drawer pages * fix: hiding drawer items logic * Update AppBar.stories.tsx * Chore/v0.2.0 (#30) * Fix/export types (#21) * 0.0.2 (#20) * add readme * fix: removing dependencies from bundle (#2) * add dependencies instalation on readme * Storybook config and first stories * feat: add readme (#1) * add readme * add dependencies instalation on readme * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * Update README.md Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * chore: resolvingconversations * chore: resolve conversations Co-authored-by: Sampaio Leal <samp14hd@gmail.com> * chore: initial config * chore: romove not necessary configs * Docs/code of conduct (#6) * add code of conduct * chore: add Breadcrumbs and Dialog tests Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * wip: snackbar tests * done: snackbar tests * chore: tests on workflow * chore: tests on workflow * chore: slobe CI problem * chore: add jsDocs * refactoring tests * fix import bugs * resolve conversations * remove warnigs * Update README.md Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> * add AppBar Components and Store * remove mui icons from dependencies * add dependencies on readme and workflow * ESBuild implemented (#16) * added esbuild * chore: solve CI Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> * chore: improve tests * upgrade dependencies * chore: upgrade dependencies * chore: add drawer attribute in Page type * lint: solve unused code Co-authored-by: Sampaio Leal <samp14hd@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * fix: folder structure of exports with cjs by default Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> * chore: exporting esm by default * Fixing Drawer click behavior (#23) * chore: updating mui * fix: drawer onClick behavior * Fixing tests and behaviors (#24) * chore: updating mui * fix: drawer onClick behavior * fix: tests and components behavior * chore: removing the comment * feat: hiding drawer pages (#27) * Fix/esbuild-path-alias (#26) * fix: typescript path alias with esbuild * chore: decorating uistore without decorators * Fix/breadcrumb-links (#25) * fix: breadcrumbs now have onClick function * fix: breadcrumb tests * 0.2.0 Co-authored-by: Gabriel Silva <devzgabriel@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com> Co-authored-by: Sampaio Leal <samp14hd@gmail.com> Co-authored-by: Sampaio Leal <SampaioLeal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.