Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix fs failures #56

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Try to fix fs failures #56

wants to merge 1 commit into from

Conversation

ThatXliner
Copy link
Collaborator

@EvanZhouDev
Copy link
Owner

EvanZhouDev commented Aug 15, 2023

Wait is it done

@ThatXliner
Copy link
Collaborator Author

Wait is it done

No, remember that I’m unable to test. The way to test if this fixes the issue is to attempt to run the code listed in the specified issue within the browser (no bundler; use the script tag)

@therealsujitk
Copy link

therealsujitk commented Aug 16, 2023

I tested this with my project, issue still exists. I can help with testing, just let me know when.

@ThatXliner
Copy link
Collaborator Author

I tested this with my project, issue still exists. I can help with testing, just let me know when.

What error did you get this time?

@therealsujitk
Copy link

What error did you get this time?

The same one.

@Aldhanekaa
Copy link
Contributor

How about we remove this feature from the library. Though we can already passed image buffer through the ask function argument.

@ThatXliner
Copy link
Collaborator Author

ThatXliner commented Aug 19, 2023

/cc @EvanZhouDev

Yea, especially when the user could have implemented it themself (unsure why the feature was originally implemented).

One thing to note is that removing this feature now is technically a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG]: Module not found: Error: Can't resolve 'fs'
4 participants