Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: 当未登录时,右键菜单只有复制按钮时,多余的分割线看着很不协调 #90

Merged
merged 6 commits into from
Jul 15, 2023

Conversation

li-junpeng
Copy link
Contributor

@li-junpeng li-junpeng commented Jul 13, 2023

🤔 这个变动的性质是? (至少选中一项)

  • 日常 bug 修复
  • 新特性提交
  • 组件样式/交互改进
  • 重构
  • 代码风格优化
  • 包体积优化
  • 性能优化
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

优化未登录时,右键菜单多余的分割线。如下图所示:
优化前:
image
优化后:
image

📝 更新日志

语言 更新描述
🇺🇸 英文
🇨🇳 中文 优化未登录时,右键菜单分割线样式

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

🚀 概述

copilot:summary

🔍 实现细节

copilot:walkthrough

@li-junpeng li-junpeng requested a review from Evansy July 14, 2023 00:55
@li-junpeng
Copy link
Contributor Author

优化了其他未登录时出现的问题。

  1. 未登录时,禁用消息内容右键菜单功能
  2. 未登录时,禁用用户列表右键菜单功能
  3. 修复: 未登录时,消息内容下方的点赞或点踩未弹出登录框的问题

Copy link
Owner

@Evansy Evansy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 PR~

@Evansy Evansy merged commit 9844e4d into Evansy:main Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants