Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting END for create persistent subscription fromRevision #154

Conversation

George-Payne
Copy link
Member

@George-Payne George-Payne commented Apr 8, 2021

  • update types
  • update command
  • add test

Note: END is sent as "18446744073709551615" in line with dotnet client behaviour.

fixes: #152

- update types
- update command
- add test
@hayley-jean hayley-jean merged commit c06e810 into master Apr 12, 2021
@hayley-jean hayley-jean deleted the allow-setting-revision-to-END-in-create-persistent-subscription branch April 12, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues which are a software defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PersistentSubscriptionSettings.fromRevision only accepts START and bigint
3 participants