Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] More Parquet benchmarking #1160

Merged
merged 9 commits into from
Jul 18, 2023
Merged

[CHORE] More Parquet benchmarking #1160

merged 9 commits into from
Jul 18, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jul 14, 2023

  1. Adds a naive "whole file downloader" read method
  2. Adds stub for a native Daft read_parquet Table method
  3. Adds more configurations of benchmarks (one column vs multi-column vs multi-sparse-columns vs all columns)

@github-actions github-actions bot added the chore label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1160 (378da7e) into main (18f21a6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1160   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files          54       54           
  Lines        5555     5555           
=======================================
  Hits         4912     4912           
  Misses        643      643           

@jaychia jaychia force-pushed the jay/more-parquet-benchmarks branch 2 times, most recently from 497fdaf to d5c692b Compare July 17, 2023 22:30
@Eventual-Inc Eventual-Inc deleted a comment from jaychia Jul 17, 2023
@jaychia jaychia force-pushed the jay/more-parquet-benchmarks branch from 5505e39 to 9eac4e6 Compare July 18, 2023 16:15
@jaychia jaychia enabled auto-merge (squash) July 18, 2023 20:09
@jaychia jaychia merged commit 512c81d into main Jul 18, 2023
@jaychia jaychia deleted the jay/more-parquet-benchmarks branch July 18, 2023 20:10
@jeevb
Copy link
Contributor

jeevb commented Jul 19, 2023

/benchmark

Daft Benchmark [#2] @ 378da7e

Download artifacts


---
History
Most recent attempts appear on the left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants