Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Consolidate to list namespace #1180

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jul 24, 2023

Closes: #1056

  • Consolidates on using .list as the namespace on both Series and Expression list operations
  • As a driveby, exposes the .list.lengths() expression (the functionality on a Series was already implemented)

@jaychia jaychia enabled auto-merge (squash) July 24, 2023 17:49
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1180 (138fde4) into main (355e494) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1180   +/-   ##
=======================================
  Coverage   88.43%   88.44%           
=======================================
  Files          54       54           
  Lines        5562     5564    +2     
=======================================
+ Hits         4919     4921    +2     
  Misses        643      643           
Impacted Files Coverage Δ
daft/expressions/expressions.py 91.78% <100.00%> (+0.04%) ⬆️
daft/series.py 92.09% <100.00%> (ø)

@jaychia jaychia merged commit b13bdf8 into main Jul 24, 2023
18 checks passed
@jaychia jaychia deleted the jay/arr-to-list-namespcae branch July 24, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate Arr and List namespace for ops
1 participant