Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] native google cloud reader #1271

Merged
merged 10 commits into from
Aug 15, 2023
Merged

[FEAT] native google cloud reader #1271

merged 10 commits into from
Aug 15, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Aug 14, 2023

  • Adds GCS support to the native io reader for urls with gs:// or gcs:// paths.
  • io_config can be configured for GCS via
    daft.io.IOConfig(
        gcs=daft.io.GCSConfig(
            project_id="...",
            #anonymous = True
        )
    )

@github-actions github-actions bot added the enhancement New feature or request label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1271 (ced1549) into main (3462d0f) will increase coverage by 0.19%.
Report is 12 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
+ Coverage   87.56%   87.75%   +0.19%     
==========================================
  Files          62       61       -1     
  Lines        5976     6021      +45     
==========================================
+ Hits         5233     5284      +51     
+ Misses        743      737       -6     
Files Changed Coverage Δ
daft/io/__init__.py 94.44% <100.00%> (ø)

... and 16 files with indirect coverage changes

@samster25 samster25 merged commit a3e38c4 into main Aug 15, 2023
18 checks passed
@samster25 samster25 deleted the sammy/native-google-cloud branch August 15, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant