Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] [New Query Planner] All functional tests pass + add to CI. #1274

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

clarkzinzow
Copy link
Contributor

This PR ensures that all functional tests pass for the new query planner and adds the new query planner to the CI job matrix; all tests are covered and pass except for the Python query planner optimization tests.

The use_new_planner test fixture is removed, since DAFT_NEW_QUERY_PLANNER=1 make test will now work with expected test coverage.

@github-actions github-actions bot added the enhancement New feature or request label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1274 (f023cec) into main (57853db) will decrease coverage by 0.21%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
- Coverage   87.71%   87.50%   -0.21%     
==========================================
  Files          61       61              
  Lines        6023     6026       +3     
==========================================
- Hits         5283     5273      -10     
- Misses        740      753      +13     
Files Changed Coverage Δ
daft/context.py 69.89% <100.00%> (-9.68%) ⬇️
daft/logical/rust_logical_plan.py 90.00% <100.00%> (+2.10%) ⬆️

... and 2 files with indirect coverage changes

@clarkzinzow clarkzinzow merged commit a4329f1 into main Aug 15, 2023
27 checks passed
@clarkzinzow clarkzinzow deleted the clark/functional-parity-new-query-planner branch August 15, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant