Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Use manylinux_2_24 for aarch64 linux to be able to publish manylinux2014 #1275

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Aug 16, 2023

  • Downgrade container version to use manylinux_2_24 so we can publish manylinux2014 wheels so that older versions of pip will work with daft.

@github-actions github-actions bot added the bug Something isn't working label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1275 (dd96629) into main (a4329f1) will decrease coverage by 13.25%.
The diff coverage is n/a.

❗ Current head dd96629 differs from pull request most recent head 877f61c. Consider uploading reports for the commit 877f61c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1275       +/-   ##
===========================================
- Coverage   87.58%   74.34%   -13.25%     
===========================================
  Files          61       61               
  Lines        6026     6026               
===========================================
- Hits         5278     4480      -798     
- Misses        748     1546      +798     

see 14 files with indirect coverage changes

@samster25 samster25 changed the title [BUG] try different container [BUG] Use manylinux_2_24 for aarch64 linux to be able to publish manylinux2014 Aug 16, 2023
@samster25 samster25 merged commit 0664353 into main Aug 16, 2023
20 checks passed
@samster25 samster25 deleted the sammy/change-linux-aarch-image branch August 16, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant