[FEAT] [Scan Operator] Add ChunkSpec for specifying format-specific per-file row subset selection for ScanTasks.
#1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1590 +/- ##
=======================================
Coverage 85.19% 85.19%
=======================================
Files 54 54
Lines 5180 5180
=======================================
Hits 4413 4413
Misses 767 767
|
jaychia
approved these changes
Nov 10, 2023
clarkzinzow
force-pushed
the
clark/row-group-selector-per-file
branch
from
d9a32d3
to
af75f86
Compare
clarkzinzow
force-pushed
the
clark/row-group-selector-per-file
branch
from
af75f86
to
3c858f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ChunkSpecabstraction + integration that allows for format-specific per-file row subset selection forScanTasks. The first concrete implementation is for Parquet, via an index-based row group selection. Pushing this down to be aScanTaskconcept makes it easier to specify things like this at a per-file level without polluting user-facing abstractions like the file format config, and should make merging/splittingScanTasks along the row dimension easier.In the future, other formats such as CSV and NDJSON could support selecting by byte range ending at row boundaries.