[BUG] Update requirements for typing_extensions #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use `from typing import ParamSpec` and fallback onto `from typing_extensions import ParamSpec` when on a version of Python < 3.10 We need to upgrade our requirements to reflect this!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
==========================================
- Coverage 85.29% 85.27% -0.02%
==========================================
Files 54 54
Lines 5161 5161
==========================================
- Hits 4402 4401 -1
- Misses 759 760 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
from typing import ParamSpecand fallback ontofrom typing_extensions import ParamSpecwhen on a version of Python < 3.10We need to upgrade our requirements to reflect this!