Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Edit 'make-hooks' command to install pre-commit script #1602

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

colin-ho
Copy link
Contributor

I noticed after following the contributing guide and running 'make hooks', the pre-commit hooks did not run when I commit changes.

Not sure if this was intended, but looking at https://pre-commit.com/#pre-commit-install-hooks:

pre-commit install-hooks does not install the pre-commit script. 
To install the script along with the hook environments in one command, use pre-commit install --install-hooks.

See also: pre-commit/pre-commit.com#255

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1602 (7e4247e) into main (b4467ad) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1602   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files          54       54           
  Lines        5222     5222           
=======================================
  Hits         4424     4424           
  Misses        798      798           

@samster25
Copy link
Member

TIL and thanks for making another PR. that's a fairly confusing matrix here

@samster25 samster25 merged commit fbbeff3 into Eventual-Inc:main Nov 13, 2023
32 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants