Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] drop s3 compat mode for gcs for anonymous mode #1682

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Nov 30, 2023

  • google-cloud-storage crate now supports anonymous mode from this issue thanks to this PR
  • This lets us drop S3 Compatibility mode for GCS

@github-actions github-actions bot added the chore label Nov 30, 2023
@samster25 samster25 changed the title [CHORE] drop s3 compat mode for gcs for anonymous mode [CHORE] [DO NOT MERGE] drop s3 compat mode for gcs for anonymous mode Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #1682 (31f5c31) into main (cb1fb22) will increase coverage by 0.02%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
+ Coverage   85.04%   85.07%   +0.02%     
==========================================
  Files          55       55              
  Lines        5341     5345       +4     
==========================================
+ Hits         4542     4547       +5     
+ Misses        799      798       -1     

see 5 files with indirect coverage changes

@samster25 samster25 changed the title [CHORE] [DO NOT MERGE] drop s3 compat mode for gcs for anonymous mode [CHORE] drop s3 compat mode for gcs for anonymous mode Dec 1, 2023
@samster25 samster25 merged commit f0ddb8c into main Dec 1, 2023
50 checks passed
@samster25 samster25 deleted the sammy/gcp-anon-mode branch December 1, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant