[FEAT] Allow overwrite / overwrite partitions for write operations #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
==========================================
+ Coverage 84.67% 84.72% +0.04%
==========================================
Files 57 57
Lines 6317 6343 +26
==========================================
+ Hits 5349 5374 +25
- Misses 968 969 +1
|
colin-ho
force-pushed
the
colin/overwrite-on-write
branch
from
d50a0da
to
95f5d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1768
This is a POC for adding overwrite / overwrite partitions mode for our write methods. The idea is to collect all the file paths that were written across partitions into a single partition via a reduce-merge step, then performing an
lsto get all the file paths in the root dir, then deleting all files that were not written as part of the write operation.