Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Return &str for expression name #2224

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented May 2, 2024

We return a DaftResult<&str> for expression names, but currently there's no case that would raise an error. Having the return type as &str should be sufficient.

@github-actions github-actions bot added the chore label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (da991c5) to head (ac5ee6e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2224   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files          71       71           
  Lines        7586     7586           
=======================================
  Hits         6493     6493           
  Misses       1093     1093           

Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samster25 samster25 merged commit 29d310b into main May 6, 2024
31 checks passed
@samster25 samster25 deleted the colin/refactor-expr-name branch May 6, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants