Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row select method docs are misleading #140

Closed
Evertras opened this issue Mar 17, 2023 · 0 comments · Fixed by #141
Closed

Row select method docs are misleading #140

Evertras opened this issue Mar 17, 2023 · 0 comments · Fixed by #141
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Evertras
Copy link
Owner

Current docs state:

// Selected sets whether the row is selected or not.

However, this is a little misleading, and caused the following code from #137 to seem reasonable:

for _, r := range m.archTable.SelectedRows() {
	r.Selected( false)
}

The docs should reflect that the row is actually copied and a new version is returned - this is not a mutating action.

@Evertras Evertras self-assigned this Mar 17, 2023
@Evertras Evertras added the documentation Improvements or additions to documentation label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant