Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resuming from a gpu model on cpu or vice versa #272

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

SamuelLarkin
Copy link
Collaborator

For Marc to test.
fixes: #271

Copy link
Contributor

github-actions bot commented Feb 16, 2024

CLI load time: 0:00.56
Pull Request HEAD: 06a6b29e4dbb19c011271b80d594aa7bdaf004de
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:       890 |     115623 |       typer.rich_utils
import time:      1407 |     117796 |     typer.core
import time:      1142 |     141760 |   typer.main
import time:       342 |     162059 | typer
import time:       434 |     109720 |       everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.synthesize
import time:       343 |     129353 |     everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.cli
import time:       249 |     130143 |   everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli
import time:        25 |     130167 | everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.preprocess

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2c0c8b0) 70.63% compared to head (06a6b29) 70.63%.

Files Patch % Lines
everyvoice/base_cli/helpers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   70.63%   70.63%           
=======================================
  Files          39       39           
  Lines        2476     2476           
  Branches      385      385           
=======================================
  Hits         1749     1749           
  Misses        658      658           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@marctessier marctessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good Sam!

Ran various test with success :
GPU->CPU->GPU
CPU->GPU->CPU
GPU->GPU
CPU->CPU

@SamuelLarkin SamuelLarkin merged commit 095aeb3 into main Feb 16, 2024
3 of 4 checks passed
@SamuelLarkin SamuelLarkin deleted the dev.sl/271_finetune_gpu_cpu branch February 16, 2024 16:39
@SamuelLarkin
Copy link
Collaborator Author

Thanks @marctessier for your help.

@SamuelLarkin SamuelLarkin changed the title [WIP] fix: resuming from a gpu model on cpu or vice versa fix: resuming from a gpu model on cpu or vice versa Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to finetune a pre-trained FP model trained on GPU with a CPU
2 participants