Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: point issue submitting to main EV repo #296

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Feb 27, 2024

No description provided.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.70%. Comparing base (01cd78e) to head (862d2af).

❗ Current head 862d2af differs from pull request most recent head 75ca553. Consider uploading reports for the commit 75ca553 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   70.85%   70.70%   -0.16%     
==========================================
  Files          39       39              
  Lines        2505     2492      -13     
  Branches      384      383       -1     
==========================================
- Hits         1775     1762      -13     
- Misses        661      662       +1     
+ Partials       69       68       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 27, 2024

CLI load time: 0:00.37
Pull Request HEAD: 75ca5530f5995fce62f7d8e1c1c7abc1d056ea25
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:       259 |     112748 | typer

Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except I think the HiFiGAN and wav2vec2 readme changes weren't included. I disabled Issues on the other repos. I'll look into making issue templates

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the PR for this wasn't created

@@ -2,6 +2,14 @@

Feel free to dive in! [Open an issue](https://github.com/roedoejet/EveryVoice/issues/new) or submit PRs.

Issues regarding the submodules should also be submitted on the main
[EveryVoice repo](https://github.com/roedoejet/EveryVoice), with the tag
`[FastSpeech2]`, `[HiFiGAN]`, `[DeepForceAligner]`, or `[wav2vec2aligner]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the wav2vec2aligner readme updated?

@joanise
Copy link
Member Author

joanise commented Feb 28, 2024

Right, I had push the branch for HiFiGAN but forgot to submit the PR. Fixed.
For wav2vec2aligner, I wavered: the repo is more stand-alone from EV, with no actual dependencies on EV, and you have not disabled issues on it, so I thought we'd want to not change its readme. But let me know if you want it the same way too, and I'll add it.

@roedoejet
Copy link
Member

Right, I had push the branch for HiFiGAN but forgot to submit the PR. Fixed. For wav2vec2aligner, I wavered: the repo is more stand-alone from EV, with no actual dependencies on EV, and you have not disabled issues on it, so I thought we'd want to not change its readme. But let me know if you want it the same way too, and I'll add it.

I think you made the right choice, since it's more stand-alone. Let's leave the issues open there.

@roedoejet roedoejet self-requested a review February 28, 2024 19:44
@joanise joanise force-pushed the dev.ej/292_issues-in-top-module branch from 862d2af to 75ca553 Compare February 28, 2024 20:12
@joanise joanise merged commit 75ca553 into main Feb 28, 2024
2 checks passed
@joanise joanise deleted the dev.ej/292_issues-in-top-module branch February 28, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contributing documentation should describe that issues should be raised in the parent repo, not submodules.
2 participants