-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: point issue submitting to main EV repo #296
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 70.85% 70.70% -0.16%
==========================================
Files 39 39
Lines 2505 2492 -13
Branches 384 383 -1
==========================================
- Hits 1775 1762 -13
- Misses 661 662 +1
+ Partials 69 68 -1 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except I think the HiFiGAN and wav2vec2 readme changes weren't included. I disabled Issues on the other repos. I'll look into making issue templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the PR for this wasn't created
@@ -2,6 +2,14 @@ | |||
|
|||
Feel free to dive in! [Open an issue](https://github.com/roedoejet/EveryVoice/issues/new) or submit PRs. | |||
|
|||
Issues regarding the submodules should also be submitted on the main | |||
[EveryVoice repo](https://github.com/roedoejet/EveryVoice), with the tag | |||
`[FastSpeech2]`, `[HiFiGAN]`, `[DeepForceAligner]`, or `[wav2vec2aligner]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was the wav2vec2aligner readme updated?
Right, I had push the branch for HiFiGAN but forgot to submit the PR. Fixed. |
I think you made the right choice, since it's more stand-alone. Let's leave the issues open there. |
862d2af
to
75ca553
Compare
No description provided.