Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom activity image file system path #24

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Add support for custom activity image file system path #24

merged 3 commits into from
Oct 29, 2020

Conversation

R3ality
Copy link
Contributor

@R3ality R3ality commented Sep 2, 2020

Add param ActivityImagePath for function New-TeamsSection which accepts file system paths to image files. Will be embedded in the JSON

Usage example:

$Section = New-TeamsSection `
    -ActivityTitle "Title" `
    -ActivitySubtitle "Subtitle" `
    -ActivityImagePath "\\VBOXSVR\share\temp2\25 microsoft teams\Images\success.png" ` # <-- Any valid file system path
    -ActivityText "Text" `
    -ActivityDetails $Fact1, $Fact2, $Fact3

Example outcome:
image

@R3ality R3ality mentioned this pull request Sep 2, 2020
Closed
R3ality
R3ality commented Sep 3, 2020
View reviewed changes
Public/New-TeamsSection.ps1 Outdated
$ActivityImageLink = Get-Image -PathToImages $FilePath -FileName $FileBaseName -FileExtension $FileExtension # -Verbose
}
elseif ($ActivityImage -ne 'None') {
$StoredImages = [IO.Path]::Combine($PSScriptRoot, 'Images')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this line should not be changed and path is intended to be updated upon publishing. See here: #22 (comment)

@R3ality
Copy link
Contributor Author

R3ality commented Sep 3, 2020

Related to issue #23

@PrzemyslawKlys PrzemyslawKlys merged commit a025273 into EvotecIT:master Oct 29, 2020
@PrzemyslawKlys
Copy link
Member

Sorry it took so long. I got preoccupied with something else and forgot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@R3ality @PrzemyslawKlys